Re: [PATCH (3)] gnu: Add NFS related services (moved idmap.conf out of /etc, added texinfo markup to documentation, s/dir/directory)

[Ludovic Courtès]

Hi!

John Darrington <address@hidden> skribis:

> * gnu/services/nfs.scm (pipefs-service-type): New Variable,
> (gss-service-type): New Variable, (idmap-service-type) New Variable.
>
> * doc/guix.texi (Network File system): New Node.

Minor issues, and a suggestion for the pipefs service:

> +The @code{(gnu services nfs)} module provides the following services,
> +which are most commonly used in relation to mounting or exporting NFS
> +file systems.

Rather something like:
“mounting or exporting directory trees as @dfn{network file systems} (NFS).”

>  @subsubheading RPC Bind Service
>  @cindex rpcbind
>  
> -The @code{(gnu services nfs)} module provides the following:
> +The RPC Bind service provides a facility to map program numbers into

s/program numbers/address@hidden program numbers/

> +universal addresses.

“IP addresses”?

+ “ (RPC stands for @dfn{remote procedure call})”

> +     (shepherd-service
> +        (documentation "Mount the pipefs pseudo filesystem.")
          ^
Extra space.

> +        (provision '(rpc-pipefs))
> +
> +        (start #~(lambda ()
> +                   (mkdir-p #$pipefs-directory)
> +                   (mount "rpc_pipefs" #$pipefs-directory "rpc_pipefs")))
> +        (stop #~(lambda (pid . args)
> +                  (umount #$pipefs-directory MNT_DETACH)))))))

There’s the problem that ‘start’ must return a truth value (to tell the
Shepherd that the service was correctly “started”), so it’s better to
add an explicit #t at the end; conversely, ‘stop’ must return #f to
denote a successful stop.

However, as mentioned at
<https://lists.gnu.org/archive/html/guix-devel/2016-09/msg01096.html>, I
think it would be best to achieve this by extending
‘file-system-service-type’.

Could you try that?  If it works, I don’t have any further comments.

> +     (define idmap-command
> +       #~(list (string-append #$nfs-utils "/sbin/rpc.idmapd") "-f"

                  #$(file-append nfs-utils "/sbin/rpc.idmapd")

> +     (shepherd-service
> +      (documentation "Start the RPC IDMAP daemon.")
        ^
Missing space this time.  :-)

Thank you!

Ludo’.