Re: [PATCH] gnu: Add irctest.

[ng0]

Hi,

thanks for reviewing

Leo Famulari <address@hidden> writes:

> On Tue, Oct 18, 2016 at 01:42:24PM +0000, ng0 wrote:
>> * gnu/packages/irc.scm (irctest): New variable.
>
> Cool!
>
>> +      (version (string-append "0.1-" revision "." (string-take commit 7)))
>
> 0.1 should be 0.0.0.

No, the setup.py has version: 0.1

>> +      (inputs
>> +       `(("python-ecdsa" ,python-ecdsa)
>> +         ("python-psutil" ,python-psutil)
>> +         ("limnoria" ,limnoria)))
>
> The output does not refer to limnoria:
>
> $ guix gc --references $(./pre-inst-env guix build irctest)
> /gnu/store/pn0lc8cl2c7ja8vgkxs2ka8w9vras8i5-python-ecdsa-0.13
> /gnu/store/qvmmdi87vypfz90n76ph5knca188wrv8-python-psutil-4.3.0
> /gnu/store/z4r53nxw185s5an6kkvs7cgdkwrl1p8l-irctest-0.1-1.548ddb5
>
> Is it just used for building? If so, it should be a native-input.
> Otherwise irctest will stop working after garbage collection.

I think this has to be propagated, I'm not really sure. I need to look
at this when I can focus again