[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] services: Add 'cuirass-service'.
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH 2/2] services: Add 'cuirass-service'. |
Date: |
Wed, 26 Oct 2016 16:42:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hello David,
David Craven <address@hidden> writes:
> Do we need to export all of these?
>
> + cuirass-configuration-cache-directory
> + cuirass-configuration-group
> + cuirass-configuration-interval
> + cuirass-configuration-database
> + cuirass-configuration-specifications
> + cuirass-configuration-use-substitutes?
> + cuirass-configuration-one-shot?
> + %default-cuirass-configuration
Since the <cuirass-configuration> data type is documented in the manual,
the idea was to export the procedures that allow manipulating this type
in a REPL. However since it appears that other services are not doing
that, I think it is better to remove them.
> Is %default-cuirass-configuration needed?
The benefit is a slightly more meaningful default value for #:CONFIG in
the 'cuirass-service' procedure documentation. However I am not sure if
that helps much. WDYT?
Thanks for the review.
--
Mathieu Lirzin