Re: [PATCH 2/2] gnu: Add emacs-org-trello.

[Ricardo Wurmus]

Roel Janssen <address@hidden> writes:

>> The cask file says:
>>
>> (development
>>  (depends-on "dash-functional")
>>  (depends-on "dash")
>
> @code{dash} provides @code{dash-functional}.
>
>>  (depends-on "undercover")
>
> This one is needed to run the tests.
>
>>  (depends-on "ert-runner")
>>  (depends-on "ert")
>>  (depends-on "ert-expectations")
>
> These should be built-in.  See:
> https://www.gnu.org/software/emacs/manual/html_node/ert/
>
> (Or M-x ert)
>
>>  (depends-on "el-mock")
>>  (depends-on "helm"))
>
> These should be added too, to run the tests.
>
> I added undercover, el-mock and helm to the inputs.

[…]

> +(define-public emacs-org-trello
> +  (package
> +    (name "emacs-org-trello")
> +    (version "0.7.9")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/org-trello/org-trello/archive/";
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-deferred" ,emacs-deferred)
> +       ("emacs-request" ,emacs-request)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-undercover" ,emacs-undercover)
> +       ("emacs-el-mock" ,emacs-el-mock)
> +       ("emacs-helm" ,emacs-helm)))

Hmm, now I wonder… I just looked at emacs.scm and only one package there
has “emacs-undercover” as an input (and it looks like this was a
mistake).  We seem not to add test inputs to Emacs packages.

@Alex: could you please confirm this?  Should these inputs be mentioned
at all?  If so, is it sufficient to add them to native-inputs?

~~ Ricardo