[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add radeontop.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add radeontop. |
Date: |
Fri, 28 Oct 2016 15:49:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi!
Tobias Geerinckx-Rice <address@hidden> skribis:
> * gnu/packages/linux.scm (radeontop): New variable.
[...]
> I'm too ignorant of anything beyond x86 to know if supported-systems is
> needed or even makes sense here.
I’m guessing the program is not very useful on non-x86 machines… but it
may build fine anyway.
We can add ‘supported-systems’ later if/when we have evidence that it
doesn’t build on other arches.
> +(define-public radeontop
> + (package
> + (name "radeontop")
> + (version "0.9")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> "https://github.com/clbr/radeontop/archive/v"
You could move ‘home-page’ above ‘source’ and reference it here.
Otherwise LGTM, thanks!
> + (license license:gpl3)))
It’s indeed v3-only, bah.
Ludo’.