[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add openfwwf-firmware.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add openfwwf-firmware. |
Date: |
Fri, 18 Nov 2016 16:04:30 -0500 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Nov 16, 2016 at 09:29:18PM -0600, Eric Bavier wrote:
> Hello Guix,
>
> We've had at least one person on IRC confirm that this firmware package
> worked for them, allowing them to use their wireless hardware.
>
> Would it be appropriate to add this to %base-firmware? The output is
> rather small.
How small?
Since they seem to work, I'd say they should be added.
> From c397f73d69326db24c211e4e2bda46e647d0e751 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Thu, 12 May 2016 13:57:01 -0500
> Subject: [PATCH] gnu: Add openfwwf-firmware.
>
> * gnu/packages/firmware.scm (b43-tools, openfwwf-firmware): New
> variables.
> +(define-public b43-tools
> + (let ((commit "8dce53297966b31b6c70a7a03c2433978dd9f288")
> + (rev "1"))
How do we choose a commit?
> + (package
> + (name "b43-tools")
> + (version (string-append "20140625-" rev "." (string-take commit 7)))
Is the timestamp some kind of upstream version string? If not, and there
is no upstream version naming, we should use 0.0.0, right?
> + #:phases
> + (let ((subdirs '("assembler" "disassembler"))) ;TODO: fwcutter
Can you expand the TODO comment?