guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Allow nfs file systems to be automatically mounted.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Allow nfs file systems to be automatically mounted.
Date: Mon, 28 Nov 2016 14:59:09 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

John Darrington <address@hidden> skribis:

> On Sat, Nov 26, 2016 at 07:37:15PM +0100, Ludovic Court??s wrote:
>      John Darrington <address@hidden> skribis:
>      
>      > * gnu/build/file-systems.scm (mount-file-system): Append target addr= 
> when
>      > mounting nfs filesystems.
>      
>      Looks like you forgot to address some of suggestions I made
>      (???string-prefix????, 
>
> Ok.  I will make that change.
>
>      ???match???, 
>
> Have another look: +    (let* ((host (match (string-split source #\:) ((h _) 
> h)))

Right, but there are other occurrences of ‘car’ for ‘getaddrinfo’.  :-)

>      and left a question unanswered (port number?):
>
> Sorry.  The answer is, no so far as I'm aware, there is no convention which 
> allows a port number to  be specifed in the source field.

OK (this would have changed the way ‘source’ is parsed.)

>      , etc)
>
> The only other thing I think you mentioned was using "if" instead of "cond".
> I can envisage that in the future there will be a need for other cases,  - 
> it's not just an either/or choice - so it seemed to me that cond was more 
> appropriate.
>      
> I am aware there is room for improvement in this patch (for example in the 
> case of IP6 addresses?)  - any help will be gratefully accepted.

‘getaddrinfo’ can return both IPv4 and IPv6 addresses, so in theory,
the patch is IPv6 Ready.

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]