[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: idris: Update to 0.99.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/2] gnu: idris: Update to 0.99. |
Date: |
Mon, 19 Dec 2016 15:13:15 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi!
David Craven <address@hidden> skribis:
> * gnu/packages/haskell.scm (idris): Update to 0.99.
[...]
> + (native-search-paths
> + (list (search-path-specification
> + (variable "IDRIS_LIBRARY_PATH")
> + (files '("idris/libs")))))
The conventional thing would be to use “lib/idris” (just like we have
“lib/perl5”, “lib/python2.7”, “lib/guile”, etc.) Could you make this
change?
I suppose it’s OK to make this change now since there are no Idris
libraries packaged yet.
> +++ b/gnu/packages/patches/idris-IDRIS_LIBRARY_PATH.patch
> @@ -0,0 +1,46 @@
> +From 8617ba8f391da875ea0d59c6b8fdce26b64e2abd Mon Sep 17 00:00:00 2001
> +From: David Craven <address@hidden>
> +Date: Sun, 6 Nov 2016 15:46:50 +0100
> +Subject: [PATCH 1/2] IDRIS_LIBRARY_PATH accepts a colon separated search
> path.
> +
> +* src/Idris/Imports.hs (installedPackages): SplitOn colon and concatMap
> + the results.
Could you indicate what the upstream status of this patch is?
If you haven’t done it yet, I encourage you to submit it upstream: it
looks like there’s no reason not to have it upstream.
Otherwise LGTM.
Thank you!
Ludo’.