[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add Prosody service.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add Prosody service.
Date: Sat, 07 Jan 2017 22:29:07 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi Clément,

Clément Lassieur <address@hidden> skribis:

> * gnu/services/messaging.scm: New file.
> * gnu/services/configuration.scm: New exported procedures.
> * gnu/packages/messaging.scm (prosody)[arguments]: Add 'fix-makefile'
>   phase.
>   In 'wrap-programs' phase, add 'openssl' and 'coreutils' to 'PATH'.
> * gnu/ (GNU_SYSTEM_MODULES): Add gnu/services/messaging.scm.
> * doc/guix.texi (Messaging Services): New section.

Great work!

I would suggest moving the gnu/packages change to a separate patch, but
apart from that I don’t have anything to add to Hartmut’s comment.

Could you send updated patches?

I suppose you confirmed with ‘guix system vm’ or similar that it works
as intended.  Could you consider writing a system test for Prosody?  The
(gnu tests mail) and (gnu tests ssh) modules provide relatively simple
examples to start from.

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]