[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add nim.

From: David Craven
Subject: Re: [PATCH] gnu: Add nim.
Date: Mon, 9 Jan 2017 18:09:17 +0100

Hi Jose,

Some changes I made:

* change module name to (gnu packages nim).
* reorder imports alphabetically.
* added you to the copyright header.
* added a comment as to why the tests are disabled.
* returned true after substitute*
* used (zero? (system* "./" ...
* removed new line after description
* added a trailing dot to the commit message headline

I don't think we need a separate /opt subfolder, opt is basically
/gnu/store for FHS systems.

Pushed as 84aafbbb664925ed1a9de3e53238bc54c743a968. Thank you!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]