[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] file-systems: Refactor file-system predicates.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 2/4] file-systems: Refactor file-system predicates. |
Date: |
Tue, 10 Jan 2017 00:21:09 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
David Craven <address@hidden> skribis:
> Updated patch, these patches now pass the basic, installed-os,
> btrfs-root-os and encrypted-root-os tests.
>
> [PATCH] file-systems: Refactor file-system predicates.
>
> * gnu/build/file-systems.scm (partition-field-reader,
> read-partition-field, %partition-label-readers,
> %partition-uuid-readers, read-partition-label, read-partition-uuid):
> New variables.
> (partition-predicate, partition-label-predicate,
> partition-uuid-predicate, luks-partition-uuid-predicate): Use
> partition field readers.
> (find-partition-by): New variable.
> (find-partition-by-label, find-partition-by-uuid,
> find-partition-by-luks-uuid): Use find-partition-by.
[...]
> +(define (read-partition-field device partition-field-readers)
Docstring please.
> +(define (find-partition-by predicate)
> + "Return the first partition found that matches PREDICATE, or #f if none
> were found."
I’d call it just ‘find-partition’.
Otherwise OK to commit, provided the relevant system tests agree. :-)
Thanks!
Ludo’.