[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add unetbootin.

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add unetbootin.
Date: Thu, 19 Jan 2017 13:20:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi Jan!

I’d suggest these minor cosmetic changes:

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 71595bf3c..d922914e9 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -337,7 +337,8 @@ permit managing file systems not included in libparted.")
     (version "625")
     (source (origin
               (method url-fetch)
-              (uri (string-append 
+              (uri (string-append
+                    "";
                     version ".tar.gz"))
               (file-name (string-append name "-" version ".tar.gz"))
@@ -353,18 +354,19 @@ permit managing file systems not included in libparted.")
              (chdir "src/unetbootin")
              (system* "lupdate" "")
              (system* "lrelease" "")
-             (system* "qmake")))
+             (zero? (system* "qmake"))))
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin")))
                (mkdir-p bin)
-                      (copy-file "unetbootin"
-                                 (string-append bin "/unetbootin"))))))))
+               (install-file "unetbootin" bin)
+               #t))))))
      `(("qt-4" ,qt-4)))
     (home-page "";)
     (synopsis "Create bootable live USB images")
-     "UNetbootin creates bootable Live USB images.")
+     "UNetbootin allows you to create bootable USB images from ISO-9660 CD/DVD
     (license license:gpl2+)))
In addition, there’s one thing we need to fix from an FSDG perspective,
which is described here:

Could you check whether the package can be adjusted to use this FUSBi
fork mentioned there, and send an updated patch?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]