[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: services: web: Add support for NGinx upstream modul

From: Ludovic Courtès
Subject: Re: [PATCH 1/2] gnu: services: web: Add support for NGinx upstream module
Date: Thu, 19 Jan 2017 14:08:13 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Christopher Baines <address@hidden> skribis:

> * gnu/services/web.scm (<nginx-upstream-configuration>): New record type.
> (<nginx-configuration>): Add new field upstream-blocks.
> (nginx-upstream): New function.
> (default-nginx-config): Add upstream-list parameter.
> (nginx-service): Add optional upstream list keyword argument.
> * doc/guix.text (Web Services): Document the new nginx-upstream-configuration
> data type and changes to the nginx function.

Applied with minor changes: no “gnu:” in the subject line, and…

> +Data type representing the configuration of an nginx upstream block.

@code{upstream}, to make it clear that this is an nginx config term.

> +prefix @samp{unix:}. For addresses using an IP address or domain name,
Two spaces.

>     "      index " (config-index-strings (nginx-server-configuration-index 
> server)) ";\n"
>     "      server_tokens " (if (nginx-server-configuration-server-tokens? 
> server)
>                                "on" "off") ";\n"
> +(define (nginx-upstream-config upstream)
> +  (string-append
> +   "    upstream " (nginx-upstream-configuration-name upstream) " {\n"
> +   (apply
> +    string-append
> +    (map (lambda (server)
> +           (simple-format #f "      server ~A;\n" server))
> +         (nginx-upstream-configuration-servers upstream)))
>     "    }\n"))

Here there was a syntax error: the last line must also be kept in the
procedure just above the hunk.  I guess that was introduced while
rebasing patches or something.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]