[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: pyt
Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.]
Fri, 20 Jan 2017 20:39:10 -0500
On Fri, Jan 20, 2017 at 03:05:42PM +0100, Ludovic Courtès wrote:
> For the pre-push hook, the overhead seems reasonable (perhaps we could
> limit the range to commits after the first signed commit to avoid
> looping for no reason?) and an improvement.
I agree that it's reasonable and an improvement for the common case of
pushing to existing branches; only the new commits' signatures are
verified in this case.
It's a good idea to limit the range when pushing new branches. It will
still fail invariably, but it will fail more quickly.
I believe the first signed commit is e3d0fcbf7e55 (gnu: Default to
Due to merges in the history (I think), using `git rev-list` to
enumerate the commits from e3d0fcbf7e55^..HEAD gives a list of commits
begins with aae03c484f21832 (gnu: Add singular.), which is an earlier
That's a little confusing, but maybe it doesn't matter if we are just
trying to save the user some time before it fails. They'll have to
disable the hook to push a branch anyways.
> Eventually we could rewrite in Scheme using guile-git, which should be
> faster (no need to fork that much).
Yes, that would be good!
Description: PGP signature