[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] services: Fix 'mkdir-p' in activation scripts.

From: Ludovic Courtès
Subject: Re: [PATCH] services: Fix 'mkdir-p' in activation scripts.
Date: Tue, 24 Jan 2017 22:21:07 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Clément Lassieur <address@hidden> skribis:

> * gnu/services/cuirass.scm (cuirass-activation): Import (guix build utils) and
>   remove (with-imported-modules '((guix build utils))).
> * gnu/services/cups.scm (%cups-activation): Idem.
> * gnu/services/networking.scm (ntp-service-activation): Idem.
> * gnu/services/mail.scm (opensmtpd-activation): Import (guix build utils).
> * gnu/services/spice.scm (spice-vdagent-activation): Idem.
> * gnu/services/ssh.scm (openssh-activation): Idem.
>   (dropbear-activation): Idem.
> * gnu/services/vpn.scm (%openvpn-activation): Idem.

Good catch!

>          (db    (dirname (cuirass-configuration-database config)))
>          (user  (cuirass-configuration-user config))
>          (group (cuirass-configuration-group config)))
> -    (with-imported-modules '((guix build utils))
> -      #~(begin
> -          (use-modules (guix build utils))
> +    #~(begin
> +        (use-modules (guix build utils))
> +        (mkdir-p #$cache)
> +        (mkdir-p #$db)

The ‘with-imported-modules’ form should be preserved: it ensures that
(guix build utils) is present in the build and/or execution environment.

It’s the other places, those that lack it, that should be fixed.  That
should go into a different patch though, and there’s no rush since those
gexps are actually used in a context where (guix build utils) happens to
be available anyway.

>  (define %cups-activation
>    ;; Activation gexp.
> -  (with-imported-modules '((guix build utils))
> -    #~(begin

Same here.

Apart from that the patch LGTM.  Could you send an updated version just
without these two things?

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]