[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add kakoune
From: |
Carlo Zancanaro |
Subject: |
Re: [PATCH] gnu: Add kakoune |
Date: |
Fri, 27 Jan 2017 10:57:42 +1100 |
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
On Thu, Jan 26 2017, Marius Bakke wrote
> Would you like to fix it? Good catch, sorry for making the mistake on
> your behalf!
No worries!
I've attached a patch to move it to a snippet. I wasn't sure how to word
the commit message (this is the first time I've updated a package), so I
hope it's okay. If not, feel free to change it.
Thanks for the comments regarding patches/snippets/phases. I think I'll
just need to hang around a bit longer and see how things are done to get
a feel for it myself.
Carlo
From b66c5ce74f15994f7976d405171771c185a646ff Mon Sep 17 00:00:00 2001
From: Carlo Zancanaro <address@hidden>
Date: Fri, 27 Jan 2017 10:48:12 +1100
Subject: [PATCH] gnu: kakoune: Move substitution phase to snippet.
* gnu/packages/text-editors.scm (kakoune): Move substitution phase to snippet.
---
gnu/packages/text-editors.scm | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index cb4855860..465c088a8 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -98,7 +98,13 @@ based command language.")
(commit commit)))
(sha256
(base32
- "19qs99l8r9p1vi5pxxx9an22fvi7xx40qw3jh2cnh2mbacawvdyb"))))
+ "19qs99l8r9p1vi5pxxx9an22fvi7xx40qw3jh2cnh2mbacawvdyb"))
+ (modules '((guix build utils)))
+ (snippet
+ ;; Kakoune uses 'gzip' to compress its manpages. Make sure
+ ;; timestamps are not preserved for reproducibility.
+ '(substitute* "src/Makefile"
+ (("gzip -f") "gzip -f --no-name")))))
(build-system gnu-build-system)
(arguments
`(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs
"out"))
@@ -117,10 +123,6 @@ based command language.")
(("if \\(m_shell.empty\\(\\)\\)" line)
(string-append "m_shell = \"" (which "sh")
"\";\n " line)))
- ;; Kakoune uses 'gzip' to compress its manpages. Make sure
- ;; timestamps are not preserved for reproducibility.
- (substitute* "src/Makefile"
- (("gzip -f") "gzip -f --no-name"))
#t))
(delete 'configure)
;; kakoune requires us to be in the src/ directory to build
--
2.11.0
signature.asc
Description: PGP signature
- Re: [PATCH] gnu: Add kakoune, Leo Famulari, 2017/01/10
- Re: [PATCH] gnu: Add kakoune, Carlo Zancanaro, 2017/01/20
- Re: [PATCH] gnu: Add kakoune, Ludovic Courtès, 2017/01/26
- Re: [PATCH] gnu: Add kakoune, Carlo Zancanaro, 2017/01/26
- Re: [PATCH] gnu: Add kakoune, Marius Bakke, 2017/01/26
- Re: [PATCH] gnu: Add kakoune, Carlo Zancanaro, 2017/01/26
- Re: [PATCH] gnu: Add kakoune, Marius Bakke, 2017/01/26
- Re: [PATCH] gnu: Add kakoune,
Carlo Zancanaro <=
- Re: [PATCH] gnu: Add kakoune, Marius Bakke, 2017/01/26
- gzip embedded timestamps, Ludovic Courtès, 2017/01/27