[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add opencascade-oce

From: Ludovic Courtès
Subject: Re: [PATCH] gnu: Add opencascade-oce
Date: Mon, 30 Jan 2017 10:26:33 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Hi Paul,

Paul Garlick <address@hidden> skribis:

> Also, there is an extra configuration flag required to successfully
> build the DRAW libraries and executable.  The '-UCMAKE_INSTALL_RPATH'
> flag is required for the validate-runpath stage to succeed.  This is to
> do with the way the global variable is initialized.  There is a
> distinction in CMake between lists and strings, which was new to me so
> I will document it here.  
> Essentially, if a variable is initialized as a single string it cannot
> subsequently be overriden by a list of strings.  The cmake instructions
> in OpenCascade (in adm/cmake/BuildToolKit.cmake) attempt to do this at
> the install stage.  The DRAW harness needs a RUNPATH including both
> .../lib and .../lib/oce-0.17.  With the standard definition of
> CMAKE_INSTALL_RPATH (from cmake-build-system.scm) the substitution of
> the INSTALL_RPATH property only includes the first string.
>  Consequently, the validate-runpath phase fails (error: library ... not
> in RUNPATH ...).  The configuration flag -UCMAKE_INSTALL_RPATH unsets
> the global variable and allows the opencascade cmake rules to do the
> work instead, setting the RUNPATH correctly for each target.
> On the subject of the 0.18 version, perhaps this could be the subject
> of a separate patch.  There could be an argument to just update in the
> normal way (instead of having two packages at once).  The issue is
> related to the hardware requirements of recent versions of OpenGL.  It
> is useful to start with 0.17 as this imposes the least restriction on
> older graphics card.  I can do some testing on the new version, later
> on, to determine how important this is.

I’ll let you decide.  :-)

> From a5f64ac9b488249027fc92c46d737d4572e57d02 Mon Sep 17 00:00:00 2001
> From: Paul Garlick <address@hidden>
> Date: Wed, 18 Jan 2017 10:01:36 +0000
> Subject: [PATCH] gnu: Add opencascade-oce
> * gnu/packages/maths.scm: Add opencascade-oce


> +    (synopsis
> +      "Libraries for 3D modeling and numerical simulation")
> +    (description "OCE stands for Open CASCADE Community Edition.  The project
> +gathers patches/improvements/experiments contributed by users over the 
> official
> +Open CASCADE library.")

I’ve changed the description to explain what Open CASCADE is, adjusted
the commit log, and committed.

Thank you!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]