[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add lmms

From: Julien Lepiller
Subject: Re: [PATCH] gnu: Add lmms
Date: Fri, 24 Feb 2017 11:56:15 +0100

On Thu, 23 Feb 2017 10:13:54 -0800
Rodger Fox <address@hidden> wrote:

> >  It's a good idea to run "./pre-inst-env guix lint PACKAGENAME"
> > which will pick up long lines for example.
> >  I have a ruler/colored line at character 83 in vim, but I'm not yet
> >  ready with the setup to write correct code again in vim. There's
> >  a similar thing for emacs.
> > 
> >  I would replace the third or second "It" with @code{LMMS} or simply
> >  LMMS.  
> Thanks for pointing that out. I missed that pre-inst-env tool in
> the manual until you just mentioned it here. That helps a lot.
> My corrected patch is attached. It passes the linter this time.
> -Rodger Fox

I've tested the patch, and it seems to work. One of the libraries
indeed cannot find its neighbor. I've loaded the functionality that is
enabled by it, and it works, but it may break at some point. Usually
runpath problems can be solved by passing "-Wl,runpath=" option to ld
during the make phase. Can you try it? Otherwise your patch is good.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]