[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] Tcsh update for core-updates

From: ng0
Subject: Re: [PATCH 0/2] Tcsh update for core-updates
Date: Fri, 24 Feb 2017 17:28:35 +0000

On 17-02-24 11:55:11, Leo Famulari wrote:
> On Fri, Feb 24, 2017 at 09:40:38AM +0000, ng0 wrote:
> > On 17-02-24 03:16:43, Leo Famulari wrote:
> > > This updates tcsh to the latest upstream version.
> > 
> > some weeks ago I worked on this. Put a significant amount of time into
> > the update, waited for replies and asked upstream about the cdhome
> > issue as I don't understand tcsh syntax that much.
> > This is exactly why I don't think email is the perfect tool for project
> > work. There is no reminder to tell you someone already worked on this,
> > no interactive search unless you have it yourself.
> > It would be good if you could search the archive next time and tell me
> > to rebase or redo it on core-updates.
> I understand that is frustrating, but I did read that discussion before
> starting to work on my patch. Also, Tobias worked on it last August.

Okay, I didn't find Tobias work either*, so blame on me too. My initial
reaction was frustration though.
(* or did I? It's too long since I worked on tcsh)
There were no updates as I waited for someone more knowledgable in the
tcsh language than myself - either upstream (where I didn't get much
help) or within our community. None of that happened and the work I did
which wasn't updated was just synced to my git.

> In both cases, there were some questions about the changes, and then the
> patch authors stopped working on the patch. Now, tcsh is blocking
> core-updates, so I decided to try updating tcsh.

Okay, that's something I wasn't involved with so I didn't know. Thanks
for letting me know.

> It's hard to take a pre-existing patch from somebody else and try to
> figure out what parts are necessary, which parts can be discarded, which
> parts should be adjusted, et cetera. Especially for a complicated
> package update that requires adjusting patch files.
> It's a lot easier to try the upgrade from scratch and fix problems as I
> find them.

I agree with this to some degree. Sometimes fixing the patch works, but
sometimes it just doesn't. I've encountered the case where it didn't
help anymore when I started working on git-shallow-clone by Andy from 2
years ago.

Anyway, no harm done, I just wanted to express what I felt.
What counts is that we don't start bulldozer'ing over each others work
and that the problem is fixed in the end.

Wether both Tobias and my work helped you or not, Thanks for fixing the
long overdue tcsh update :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]