[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners pat
Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types.
Mon, 27 Feb 2017 11:27:47 +0100
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
On Mon 27 Feb 2017 10:39, Clément Lassieur <address@hidden> writes:
> Clément Lassieur <address@hidden> writes:
>> Andy Wingo <address@hidden> writes:
>>> On Sun 26 Feb 2017 20:42, Clément Lassieur <address@hidden> writes:
>>>> * gnu/services/mail.scm (unix-listener-configuration)[path]
>>>> (fifo-listener-configuration)[path]: Change type from 'file-name' to
>>>> * doc/guix.texi (Mail Services): Document it.
>>> Why's that? Is the extra checking from the file-name type (that the
>>> string start with "/") getting in the way of something?
>> Yes, because the path is also used as the section name (see
>> So for example, this code (from gnu/services/mail.scm:445) raises an
>> error because "lmtp" doesn't start with "/":
>> (kind "lmtp")
>> (list (unix-listener-configuration (path "lmtp") (mode "0666")))))
>> I don't understand how it could work before. Maybe the check wasn't
> Well, maybe here "lmtp" is not the section name, but the path, relative
> to "base_dir". Sould I update the documentation to specify that "path"
> may be relative to "base_dir" too?
Sure, anyway patch LGTM. Thanks for taking the time to explain.