guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add jacal.


From: Leo Famulari
Subject: Re: [PATCH 3/3] gnu: Add jacal.
Date: Mon, 27 Feb 2017 19:31:11 -0500
User-agent: Mutt/1.7.2 (2016-11-26)

On Sun, Feb 26, 2017 at 08:42:28PM +0100, John Darrington wrote:
> * gnu/packages/maths.scm (jacal): New variable.
> * gnu/packages/patches/jacal.texi.patch: New file.

Can you rename the patch jacal-texi.patch (for consistency with the
majority of the patches) and add a comment in the patch file explaining
what it does?

> +         (replace 'configure
> +                  (lambda* (#:key inputs outputs #:allow-other-keys)
> +                    (zero? (system* "./configure"
> +                                    (string-append "--prefix="
> +                                                   (assoc-ref outputs 
> "out")))))))))

This can be done in #:configure-flags, right?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]