[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add fpc. (version 2)

From: Danny Milosavljevic
Subject: Re: [PATCH] gnu: Add fpc. (version 2)
Date: Tue, 14 Mar 2017 22:45:27 +0100


>+                   (copy-file (assoc-ref inputs "fpc-binary")
>+                              "fpc-bin.tar")
>+                   (zero? (system* "tar" "xvf" "fpc-bin.tar")))))

Why the copy-file and then untar ? Can't it be untarred immediately from where 
it is? If it is useful, maybe add a comment about the reason.

Also, it might be easier to have a fpc-bootstrap package with the bootstrap 
binaries that installs the binaries required to build fpc normally and to make 
a fpc package depend on fpc-bootstrap as native-inputs.  What do you think?  I 
myself don't have a strong preference about it - but some other packages do it 
that way.

About the fpc-reproducibility.patch , it might make sense to file bugs upstream 
about it so they add it on their side.

Also, these existing bootstrap compilers on sourceforge do not produce bit 
reproducible executables, right?  Should they also have the same patch applied 
upstream in the future ?

Overall LGTM!

fpc supports armhf and usually so do we - although not here.  We can add armhf 
support in a future patch, though.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]