|Subject:||Re: gnu: add you-get|
|Date:||Sat, 8 Apr 2017 10:57:34 +0200|
Hi Feng Shu,Thanks or contributing to Guix !
This patch for you-download is almost good, just a few notes:
+ (name "you-get")
+ (version "0.4.652")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ version "/you-get-" version ".tar.gz"))
+ (build-system python-build-system)
+ (arguments '(#:tests? #f))In the source code I can find no tests. But a comment about tests absence, here, would be preferable.Would you mind to add it ?
Also, on the home page of this project I see that Ffmpeg or libva are dependencies but the are no inputs or propagated inputs in this package definitionI didn't try to run this package but I suppose it won't run properly.Am I wrong ?
+ (synopsis "Download videos, audios or images from the websites")
+ "you-get is a tiny command-line utility, which can download media
+contents (videos, audios, images) from the Web, in case there is no other
+handy way to do it.")
+ (home-page "https://you-get.org/")
+ (license license:expat)))
I downloaded the tarball from git and the source files in the folder "cli_wrapper" are empty.Both Gedit and nano can read no linesSome files have a size of 0Others are extremely smallI don't know what this could be.Can you confirm that instead they are correctly written ?Or are they empty or you too ?Also, you should add a line about copyright attribution to yourself.At the beginning of the file there are many lines like this
;;; Copyright © 2017 humanitiesNerd <address@hidden>You should add one or yourself.As you can see, niknames are ok ;-)Would you send a new patch with these suggestions integrated ?Thanks and welcome !
|[Prev in Thread]||Current Thread||[Next in Thread]|