[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: go: Update to 1.8.1

From: Petter
Subject: Re: [PATCH] gnu: go: Update to 1.8.1
Date: Mon, 17 Apr 2017 15:37:49 +0200

Hi Sergei,

I definitely think your fix deserves recognition. Without it I would certainly have been unable to build 1.8(.1)? this month. While editing the recipe is trivial mechanical wise, figuring out what to change was not :)

Sorry to hear about your issues; I'm on x86_64 and Linux as well though...

$ /gnu/store/b4gflqj64yvksq7959r6m22mf9lzdy69-go-1.8.1/bin/go version
go version go1.8.1 linux/amd64

Hope you'll be able to work this out!

Thanks for fixing Go 1.8 :)


On 2017-04-17 14:54, Sergei Trofimovich wrote:
On Mon, 17 Apr 2017 14:16:06 +0200
Petter <address@hidden> wrote:


With this patch I'm not sure how to properly handle Copyright. I've
taken a guess and prepared a
patch anyway.

Here's the situation.

Updating to 1.8 was not trivial. A fix has been posted in a comment by
Sergei Trofimovich on
github[1]. It's a proper Guix patch, updating Go to 1.8, with the fix
and the trivial update stuff,
but as far as I can see not actually submitted to Guix.


After this Go 1.8.1 has been released. The attached patch has the
trivial update stuff for 1.8.1
and the fix by Sergei. I added Sergei to the Copyright section, but I'm
not sure if this is
correct, and if this is the way to do it. Also, I didn't find his e-mail
address, so I just added
his github page, in ()...

A little messy, please let me know if I should do something differently.

I consider the fix itself trivial thus I'm perfectly fine with not being
attributed at all. Apologies for making it hard to track me down.
I've added one of emails to github's front page.

[ While the fix is trivial debugging was a bit more fun :) ]

If you still like to add attribution (or have other reasons) feel free
to add "Sergei Trofimovich <address@hidden>"

I didn't get to submitting something that works because some unrelated
go-1.8.0 tests failed for me.

go-1.8.1 fails in a similar way, but if it works for you
it's very probable just my environment (x86_64-linux):

guix-master $ ./pre-inst-env guix build go-1.8

  ##### ../misc/cgo/test
  runtime/cgo: pthread_create failed: Resource temporarily unavailable
  scatter = 0x55ffc0
  hello from C
  sqrt is: 0
  SIGABRT: abort
  PC=0x7ffff71232c4 m=12 sigcode=18446744073709551610

Thanks for finishing go update!

Attachment: 0001-gnu-go-Update-to-1.8.1.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]