Re: [PATCH] gnu: Add cool-retro-term.

[Petter]

Hi Eric,

On Thu, 4 May 2017 22:03:24 -0500
Eric Bavier <address@hidden> wrote:

> Hello Petter,
> 
> Pushed as f9ff014bf623071b9343265e8a5aa994a10ec9d4 !

Cool! :)

> I ended up whitelisting a few more of the fonts, after verifying their
> licenses, and made some more specific notes on the license of each
> font.

Nice! I appreciate you taking care of this. My interest and knowledge of
licensing is pretty low, so I find this quite daunting at the moment. I'm sure
this will be easier for me when I gain more knowledge.

I see you updated both the snippet and the patch for the settings menu. Good!

Maybe we should start, or perhaps encourage the FSF, to maintain a list of Free
fonts. Guess this isn't the last time we need to determine a font's license.
Just a thought.

> I had to add $out/qml to the wrapper QML2_IMPORT_PATH in order for crt
> to start up.  I figured that was alright, since that path was present
> in your initial patch.

Hm. Yeah, it certainly looks alright; in fact it looks "too alright". I don't
really understand now how this even can work for me without it. This is after
all where the qml for the embedded library is, which I assume is quite
important for the program :)

Aha! I had to investigate and now I get it. I've been using cool-retro-term
since the first time I was able to start it. At this point I built it with
(inputs qml). The wrapper at this point added only cool-retro-term/qml to
QML2_IMPORT_PATH (what you've added again). And QML2_IMPORT_PATH has been set
to this in my terminal environment ever since, and have further been included by
the wrapper script when I've run later builds:
  export QML2_IMPORT_PATH=
  "...988icm-qtquickcontrols-5.7.1/qml${QML2_IMPORT_PATH:+:}$QML2_IMPORT_PATH"

Now, when I went from full qml to qml components, I checked if this was still
required (wasn't thinking). It built and started fine without it so I removed
it.

Good thing you tried it!

> I added the patches to dist_patch_DATA in gnu/local.mk and listed them
> in the commit log too.

Thanks! I'm not familiar with gnu/local.mk. Looks like a build script.

I see you also changed (assoc-ref %build-inputs ..) to use "inputs". Noted!

> It even builds with "--rounds=2" :)

Yay! :)

> Thanks again,
> `~Eric

Thanks yourself! :)
Petter

pgpDiclcUI7uE.pgp
Description: OpenPGP digital signature