[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Status of Submitted Patches
From: |
Ricardo Wurmus |
Subject: |
Re: Status of Submitted Patches |
Date: |
Thu, 24 May 2018 22:00:21 +0200 |
User-agent: |
mu4e 1.0; emacs 25.3.1 |
Hi Sahithi,
>> Another note about style: I think it would be better to use
>> “alist->hash-table” instead of “make-hash-table” followed by repeated
>> modifications to the hash table with “hashq-set!”. We prefer to avoid
>> mutation of values when possible.
>
> I have made all necessary modifications. Can please review it once.
Thanks, this looks fine.
You don’t need (srfi srfi-13) for “string-join”.
>> Regarding copyright headers: please make sure to also add a copyright
>> line for yourself and a copyright line from the file of guile-colorize
>> to “(guix ui)”.
>>
>> When you’re done with these changes, please make a local commit and send
>> the output of “git format-patch -1”.
>
>
> I will proceed further once it is reviewed. :)
Please proceed with the patch. I’d like us to make progress a little
more quickly going forward.
Thanks!
--
Ricardo
- Re: Status of Submitted Patches, Sahithi Yarlagadda, 2018/05/11
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/11
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/12
- Re: Status of Submitted Patches, Sahitihi, 2018/05/15
- Re: Status of Submitted Patches, Sahitihi, 2018/05/23
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/25
- Re: Status of Submitted Patches, Sahitihi, 2018/05/24
- Re: Status of Submitted Patches,
Ricardo Wurmus <=
- Re: Status of Submitted Patches, Sahitihi, 2018/05/24
- Re: Status of Submitted Patches, Ricardo Wurmus, 2018/05/25
- Patch file for colorize module, Sahitihi, 2018/05/25
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Ricardo Wurmus, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Ricardo Wurmus, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Sahitihi, 2018/05/26
- Re: Patch file for colorize module, Ricardo Wurmus, 2018/05/26