[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 02/02: build-system/r: Use invoke.
From: |
Mark H Weaver |
Subject: |
Re: 02/02: build-system/r: Use invoke. |
Date: |
Thu, 31 May 2018 14:26:52 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi Ricardo,
address@hidden (Ricardo Wurmus) writes:
> rekado pushed a commit to branch core-updates
> in repository guix.
>
> commit babeea3f9f46c1f1f812e590f46283e91684f327
> Author: Ricardo Wurmus <address@hidden>
> Date: Thu May 31 09:16:01 2018 +0200
>
> build-system/r: Use invoke.
>
> * guix/build/r-build-system.scm (invoke-r): Use invoke.
> (pipe-to-r): Raise invoke-error on non-zero return value.
> (check): Unconditionally return #t.
Thanks for this! However:
> (define (pipe-to-r command params)
> (let ((port (apply open-pipe* OPEN_WRITE "R" params)))
> (display command port)
> - (zero? (status:exit-val (close-pipe port)))))
> + (let ((code (status:exit-val (close-pipe port))))
> + (unless (zero? code)
> + (raise (condition ((@@ (guix build utils) &invoke-error)
> + (program "R")
> + (arguments (string-append params " " command))
> + (exit-status (status:exit-val code))
> + (term-signal (status:term-sig code))
> + (stop-signal (status:stop-sig code)))))))))
The 'arguments' field should be a list, not a string.
Thanks!
Mark
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: 02/02: build-system/r: Use invoke.,
Mark H Weaver <=