Re: GSoC update

[Jelle Licht]

2018-07-11 0:40 GMT+02:00 Ludovic Courtès <address@hidden>:

Hi Ioannis,

Ioannis Panagiotis Koutsidis <address@hidden> skribis:

> This patch adds initial support for .socket unit files. It does not
> currently work but is near completion.

Could you expound a bit?  That’s a very short summary for all the sweat
you’ve put in it.  :-)

Also, what is the patch against?  It’s not against ‘master’; I suppose
it’s against the previous state of your own branch, do you have a copy
of your repo on-line?

> During the past month I also worked on a patch that adds signalfd and
> fiber support but these are currently way too unstable and for that
> reason I have not included them in this patch.

It’s OK that the thing doesn’t quite work—we knew it was not an easy
task.  What’s disappointing though is that you didn’t come to us to
discuss the issues until now.  GSoC is not about working in all
loneliness separately from the rest of the group; it’s about becoming
part of the group.

On IRC Jelle and I (and possibly others) offered help on the ‘signalfd’
issue; I also outlined reasonable milestones (first, only use
signalfd(2) instead of SIGCHLD, then discuss together what it would take
to Fiberize the whole thing.)  It’s sad that you remained stuck instead
of taking this opportunity to discuss it with us.

Ioannis, could you perhaps share some of your w.i.p. code regarding

signalfd-based signal handling in guile? Adding to what Ludo'
mentioned, I imagine you are running into some peculiarities regarding
guile's way of handling signals, so I would recommend to start

lurking on #guile if you did not do this before now, so you can interact

with the folks with the most expertise regarding the problems you

might be facing :-)

> From cd260ae65056b53749e7c03f2498a28af2525934 Mon Sep 17 00:00:00 2001
> From: Ioannis Panagiotis Koutsidis <address@hidden>
> Date: Tue, 10 Jul 2018 20:03:21 +0300
> Subject: [PATCH] .socket units
>
> ---
>  modules/shepherd.scm         |  44 +++--
>  modules/shepherd/service.scm | 170 ++++++++++-------
>  modules/shepherd/systemd.scm | 354 ++++++++++++++++++++++++-----------
>  3 files changed, 368 insertions(+), 200 deletions(-)

The patch changes lots of things and unfortunately, without
explanations, I do not understand what to do with it.  Like what’s the
new feature?  How is it used?  What implementation choices were made?
What’s left to be done?…

Thank you,
Ludo’.