|
From: | Tatiana Sholokhova |
Subject: | RE: packaging Bootstrap for Cuirass' web interface |
Date: | Tue, 24 Jul 2018 22:29:03 +0200 |
Hi, Clement! Done! =) I’ve changed commit message with static files and rebased the latest commits, so my branch has only two commits now as we discuss before. -- Best regards, Tatiana От: Clément Lassieur Ludovic Courtès <address@hidden> writes: > Hi there! > > Gábor Boskovits <address@hidden> skribis: > >> Clément Lassieur <address@hidden> ezt írta (időpont: 2018. júl. 23., >> H, 9:48): >> >>> Hello! >>> >>> We are going to embed Bootstrap files to our Cuirass service. Wouldn't >>> it be better to package Bootstrap and get the service to use the package >>> directly? I think it would make maintenance easier, and I'm unsure it's >>> good to have huge files on which we don't have control in our Cuirass >>> git repository. WDYT? >>> >>> >> I think this is a good idea. However, I think we can go on as is for now, >> and refactor later. > > I agree. > > Actually I think bundling (a subset of) Bootstrap in Cuirass would be > acceptable because Bootstrap is not the kind of thing usually provided > as a package. > > However, bundling should be done in a way that makes it easy to track > where those files come from and to update them. We could either use a > Git submodule, or have clear commit messages that specify the repo and > commit that we used. Understood. I prefer clear commit messages to submodules :-) Tatiana, could you please add the version and the repo link to the commit message that adds static files? The idea is that people should be able to update it easily. If there is anything special, any kind of complicated procedure, that we need to follow in order to upgrade Bootstrap, could you write it in a README? But I imagine it should be fairly simple. Thank you, Clément |
[Prev in Thread] | Current Thread | [Next in Thread] |