Re: Patch Tracker no. 33214

[Lakshmi Prasannakumar]

+ Björn and dev group.

Thanks,

Lakshmi Prasannakumar
Bangalore

On Wed, Oct 31, 2018 at 11:04 PM Lakshmi Prasannakumar <address@hidden> wrote:

Hi Gábor,

I have sent the new file. Waiting for the tracker id. Meanwhile I would like to get clarification on few of the steps on verifying our package definitions.

The doc mentions about running
guix lint package and
guix build package





But both of these commands returns no  unknown package when I run them for 'weights'. Is it because I need to complete any other steps apart from modifying cran.scm file ?


Lakshmi Prasannakumar
Bangalore

On Wed, Oct 31, 2018 at 3:51 PM Lakshmi Prasannakumar <address@hidden> wrote:

Sure , I'll do that. 

On Wed 31 Oct, 2018, 3:49 PM Gábor Boskovits, <address@hidden> wrote:

Hello Laksmi,

Lakshmi Prasannakumar <address@hidden> ezt írta
(időpont: 2018. okt. 31., Sze, 10:30):
>
> Hi Gábor,
>
> I'm sending an email with the tracker no. cc-ing both of you. This is the number I received from the bug tracker. Below is the link from the bug tracker.
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33214
>

Thanks for the tracker id. I did not find it because I was looking in
a slightly wrong way (I was looking for r-weight) :)

In guix, there is a convention on the commit messages, you can see it
in git log, it is also
documented in the coding conventions.

In this case it should look something like this:

gnu: Add r-weight.

* gnu/packages/cran.scm (r-weight): New variable.

You can modify the commit message using git commit --amend, then
create a new patch and send that.

I will test this package, and report back later.



> Do let me know if I need to commit again and create a patch file, as this was the first time I committed, I'm not completely sure if it was right or not.
>
> Thanks,
> Lakshmi Prasannakumar
> Bangalore