Re: 01/01: python: Honor '--cores=...' in tests.

[Christopher Baines]

Eric Bavier <address@hidden> writes:

> On Fri, 14 Dec 2018 15:50:37 +0000
> Christopher Baines <address@hidden> wrote:
>
>> Christopher Baines <address@hidden> writes:
>>
>> > Eric Bavier <address@hidden> writes:
>> >
>> > Since all the python packages look to inherit from python-2.7 that's
>> > being changed here, perhaps this worked for some of them (I know you
>> > mentioned python-minimal in one message), but not all of them, or at
>> > least python2?
>>
>> Just got around to testing this, moving this change to python-3.7, from
>> python-2.7 fixes the python-2.7 build for me, but I haven't checked
>> how that affects how many cores are actually used when running the tests.
>
> Strange.  I recall testing this patch on both python2 and python.  Not
> sure what has changed since then.

Ok, I've checked out the relevant commit and I can reproduce the issue
there. I've also tried to compare the behaviour between the python2 and
python3 packages.

I think the reason why it might work for python3, and not python2, is
that the python2 package seems to include the -l option by default,
whereas the python3 package doesn't. Looking at the -l option, it's
something about detecting tests that leak memory, which doesn't sound
that important, so maybe the thing to do is to patch out the use of -l
in the python2 package.

What do you think?

Thanks,

Chris

signature.asc
Description: PGP signature