[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.

From: Mark H Weaver
Subject: Re: 07/07: gnu: emacs-ghub: Update to 3.2.0.
Date: Fri, 11 Jan 2019 15:04:57 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Jelle Licht <address@hidden> writes:

> Mark H Weaver <address@hidden> writes:
>> Hi Jelle,
>> [...]
>> In toplevel form:
>> magit-reset.el:30:1:Error: Cannot open load file: No such file or directory, 
>> graphql
>> make[1]: *** [Makefile:65: magit-reset.elc] Error 1
>> make[1]: Leaving directory 
>> '/tmp/guix-build-emacs-magit-2.13.0.drv-0/magit-2.13.0/lisp'
>> make: *** [Makefile:72: lisp] Error 2
> I am not quite sure what goes wrong, but I do know that ghub and magit
> should probably be updated in lockstep. I reverted the patch for now and
> will push it once I have verified other things still work. Later I will
> update everything at once when emacs-forge is properly released.

Sounds good, thanks.

> BTW, how does our one-change-per-patch policy apply when running into
> situations where multiple changes have to be made at once in order to
> keep everything building correctly?

In this case, I would keep them as separate commits, but push them at
the same time.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]