[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Package gmsh: best practise with test-suite?
From: |
Ricardo Wurmus |
Subject: |
Re: Package gmsh: best practise with test-suite? |
Date: |
Tue, 12 Feb 2019 08:45:34 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Christopher Baines <address@hidden> writes:
>> If I understand well, the idea should be to turn off the all tests
>> ("#:tests? #f") and to add a final phase calling "ctest" with the
>> correct tests. Does this make sense?
>
> That would work, but in my opinion a neater approach would be to keep
> #:tests? as #t, and replace the 'check phase to call ctest with the
> required arguments. Then #:tests? still works as an argument. Something
> like...
>
> (arguments
> '(#:phases
> (modify-phases %standard-phases
> (replace 'check
> (lambda* (#:key tests? #:allow-other-keys)
> (when tests?
> (invoke "ctest" "--exclude-regex" "..."))
> #t)))))
You can also set test arguments in an earlier phase as is done in
“dune-common”, for example.
--8<---------------cut here---------------start------------->8---
(add-after 'unpack 'disable-failing-tests
(lambda _
(setenv "ARGS"
(string-append "--exclude-regex '("
(string-join
(list
"remoteindicestest"
"remoteindicestest-mpi-2"
"syncertest"
"syncertest-mpi-2"
"variablesizecommunicatortest"
"variablesizecommunicatortest-mpi-2"
"arithmetictestsuitetest"
"assertandreturntest"
"assertandreturntest_ndebug"
"concept"
"debugaligntest"
"mpicollectivecommunication"
"mpicollectivecommunication-mpi-2"
"mpiguardtest"
"mpiguardtest-mpi-2"
"mpihelpertest"
"mpihelpertest-mpi-2"
"mpihelpertest2"
"mpihelpertest2-mpi-2")
"|")
")'"))
#t))
--8<---------------cut here---------------end--------------->8---
--
Ricardo