[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 01/01: gnu: php: Disable failing tests on armhf.
From: |
Ludovic Courtès |
Subject: |
Re: 01/01: gnu: php: Disable failing tests on armhf. |
Date: |
Fri, 29 Mar 2019 09:25:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello!
address@hidden skribis:
> commit e8cfce439afed945e352ad28f73f0a5f7840f503
> Author: Julien Lepiller <address@hidden>
> Date: Thu Mar 28 22:55:17 2019 +0100
>
> gnu: php: Disable failing tests on armhf.
>
> * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf.
[...]
> + ,@(if (string-prefix? "armhf" (or (%current-system)
> + (%current-target-system)))
> + ;; Drop tests known to fail on armhf.
> + '((for-each delete-file
> + (list
> + "ext/calendar/tests/unixtojd_error1.phpt"
> + ;; arm can be a lot slower, so a
> time-related test fails
> + "ext/fileinfo/tests/cve-2014-3538-nojit.phpt"
> + "ext/pcre/tests/bug76514.phpt"
> + "ext/pcre/tests/preg_match_error3.phpt"))))
I think the ‘else’ branch is missing, which presumably breaks PHP on
non-ARM platforms.
Also, ‘%current-target-system’ is a GNU triplet, typically
“arm-linux-gnueabihf”, which doesn’t start with “armhf”. I think the
test should be (string-prefix? "arm" …).
Thanks,
Ludo’.
- Re: 01/01: gnu: php: Disable failing tests on armhf.,
Ludovic Courtès <=