[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/01: guix: Simplify and robustify lzread!.

From: Ludovic Courtès
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Wed, 08 May 2019 11:52:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Hi Pierre!

address@hidden skribis:

> commit ecfc54403e2a1934b4f6e84ddad429b7970091fa
> Author: Pierre Neidhardt <address@hidden>
> Date:   Tue May 7 18:40:40 2019 +0200
>     guix: Simplify and robustify lzread!.
Should be lzlib.

>     * guix/lzlib.scm (lzread!): Do it.
>     Previously lzread! would fail if COUNT was bigger
>     than (lz-decompress-write-size).  This is possible if a previous call to
>     lzread! didn't empty the LZ_decompress input buffer (e.g. BV was too 
> small to
>     fit all the data).

Could you add a test for this corner case?  It’s corner cases like that
that can spoil the whole experience, so it feels safer to add tests as
soon as we encounter them.  :-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]