[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Rust dependency on git

From: Ivan Petkov
Subject: Re: Rust dependency on git
Date: Sat, 25 May 2019 12:32:30 -0700

Hi Marius

> On May 24, 2019, at 3:45 AM, Marius Bakke <address@hidden> wrote:
> It seems odd to me that the release tarballs would run 'git ls-files'
> anyway.  Do they actually contain a git repository?  Would it work to
> simply replace the invokation with 'find’?

Managed to get a chance to dig into this a bit more. The tidy test as a pass
to ensure that no binary files have been accidentally committed into the
repository. It seems like a slight oversight in assuming that the test suite is
run directly on the source repo and not from a source tarball.

It only takes commenting out a single line to unblock things for building in 
(I'll be submitting a patch once I can verify it builds locally). I'll also try
to open an issue upstream.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]