[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."

From: Jonathan Brielmaier
Subject: Re: 01/02: Revert "gnu: openssh: Clean-up custom install phase."
Date: Thu, 27 Jun 2019 10:05:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1

On 6/27/19 8:16 AM, Tobias Geerinckx-Rice wrote:
> Mark,
> Mark H Weaver wrote:
>> I don't doubt that reverting these commits was the right thing to do,
>> but it would be good to know _why_ they were reverted.  Can you provide
>> a link to a relevant discussion, or else explain it here?
> They remove .../var/empty which breaks ssh-daemon.
>> In general, when reverting commits, I think it would be useful to
>> include an explanation in the commit log.  What do you think?
> You're probably asking the wrong person.  I'm all for it.  It's not the
> done thing in Guix, tho'.

I don't think that the GNU standard forbids explanations additionally to
the required change description. Personally I often miss this, because
the commit description describes often only the obvious and not the
_reasoning_ :(

A good example for that are commit messages from IBM at the kernel :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]