[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[core-updates] Should we patch icu4c?

From: Marius Bakke
Subject: [core-updates] Should we patch icu4c?
Date: Sun, 21 Jul 2019 17:02:04 +0200
User-agent: Notmuch/0.29.1 ( Emacs/26.2 (x86_64-pc-linux-gnu)

Node's "parallel/test-intl" fails on the 'core-updates' branch when
built for i686-linux:

--8<---------------cut here---------------start------------->8---
not ok 1254 parallel/test-intl
  duration_ms: 1.308
  severity: fail
  exitcode: 1
  stack: |-
        throw newErr;
    AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command 
failed: /tmp/guix-build-node-10.16.0.drv-0/node-v10.16.0/out/Release/node -p 
new Intl.NumberFormat().resolvedOptions().locale
    munmap_chunk(): invalid pointer
        at ChildProcess.exithandler (child_process.js:294:12)
        at ChildProcess.emit (events.js:198:13)
        at maybeClose (internal/child_process.js:982:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
--8<---------------cut here---------------end--------------->8---

This is a regression test for a problem in ICU 64:

Apparently the V8 workaround only works on 64-bit?

The test succeeds if I build Node with a patched ICU:

--8<---------------cut here---------------start------------->8---
(define %icu4c-patches
  (list (origin
          (method url-fetch)
          (uri (string-append "";
          (file-name "icu4c-datetime-regression.patch")
          (method url-fetch)
          (uri (string-append "";
          (file-name "icu4c-locale-mapping.patch")
--8<---------------cut here---------------end--------------->8---

The last patch is sufficient to fix this problem, but the other seems
nice to have.  They are taken from the upstream "maint-64" branch:

I suspect the locale issue will show up in more packages as we go.

Patching ICU is a good opportunity to fix these issues:

...since they would not add to the ~50% rebuild count and armhf still
has not gotten this far.

Any volunteers for the second issue (add Python 3 support to Boost)?

CMake experts are welcome to join me in the first quest on #guix :-)

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]