Re: Please merge guix-patches bug: 36789-36800

[Tobias Geerinckx-Rice]

Zimoun,

zimoun 写道：
> Hi Tobias,
>
> Thank you for your quick answer.

You're very welcome.

> On Wed, 24 Jul 2019 at 20:47, Tobias Geerinckx-Rice 
> <address@hidden> wrote:
> > You can perform actions like this yourself by sending mail to
> > address@hidden.  Here's some documentation[0] and a
> > caveat[1].
>
> I did not know. I thought that only person with super power 
> could do that.

Your implication that this is a huge potential security hole is 
correct.  And yet, strangely, it works in practice.

> So I will do.
>
> However, I am not sure to understand how the merge needs to be 
> ordered.
> I have tried with 36789 and 36790.

Your attempt looks successful to me[0]:

 ”Merged [snipped]. Request was from zimoun <…> to control@….
  (Wed, 24 Jul 2019 19:18:02 GMT)”

You should have got a confirmation e-mail as well.

However…  Note[0] that you were attempting to merge two 
already-merged bugs.  Merged bugs act as one flesh, so you got a 
confusing response with all previous 11 numbers and the net effect 
of your command was zero.

> > What I do is to just manually write a cover letter in my MUA, 
> > send
> > it to guix-patches@, and wait for the response with the bug
> > number.  I have to keep an eye on my inbox anyway, so I don't 
> > see
> > the point of doing that on the command line.
>
> If I understand well, the basic workflow is:
>
>   git format-patch -N --cover-letter -o patches

Oh, I really meant ‘manually’ as in I fire up my MUA (emacs in 
this case), write a ‘sup geeks here's a patch series that frobs 
foo’, add ‘[PATCH 0/n]’ to the subject by hand like an animal, 
and send it to guix-patches@.

Does your command above generate a pretty diffstat or something? 
It probably does.

>   edit patches/0000-cover-letter.patch
>   # send as you want patches/0000-cover-letter.patch to 
>   guix-patches@
>   rm patches/0000-cover-letter.patch

If you do want to send a *file* like this then yes, it is indeed 
easier to use sendmail or a similar command-line tool.  I don't 
know the syntax for it by heart, though.

>   # wait the bug number
>   git send-email --to=address@hidden patches/*.patch

Since I don't need to edit anything I don't write my patches to 
the file system first.  I use ‘git send-email … -7’ and away 
they go.  But this is getting into personal preference territory 
:-)

Kind regards,

T G-R

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36789#30

signature.asc
Description: PGP signature