[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] http: Support fetching builds by derivation.
From: |
Christopher Baines |
Subject: |
Re: [PATCH] http: Support fetching builds by derivation. |
Date: |
Wed, 02 Oct 2019 08:26:26 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Ludovic Courtès <address@hidden> writes:
> Hello!
>
> Christopher Baines via "Development of GNU Guix and the GNU System
> distribution." <address@hidden> skribis:
>
>> There's a one to one mapping of build id to derivation, so allow querying by
>> derivation file name as well. I'm looking at this as I'm interested in
>> getting
>> build information in to the Guix Data Service.
>>
>> * src/cuirass/http.scm (url-handler): Add new clause to match statement, to
>> return build information by derivation file name.
>
> [...]
>
>> + (("build" "gnu" "store" derivation-file-name)
>
> Perhaps we can avoid /gnu/store in the URL, and…
>
>> + (let* ((full-derivation-file-name
>> + (string-append "/gnu/store/" derivation-file-name))
>
> … use (%store-prefix) instead of "/gnu/store" here
Sure, I've sent another patch with these changes.
Thanks,
Chris
signature.asc
Description: PGP signature