[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Packaging Jami progress

From: Pierre Neidhardt
Subject: Re: Packaging Jami progress
Date: Thu, 05 Dec 2019 15:32:23 +0100


The first 5 commits look good overall.
For the last one, I think there are a few confusions:

- native-inputs takes packages or origins, it does not take a lambda.

- To call a custom function from the builder, you need to include the
  module that defines it for the build system, e.g.

    `(#:modules ((gnu packages telephony)

- In this particular case, you could even make a macro that is expanded
  at definition time, so that you would not even need to import the module.
  If you don't know how to write scheme macros, no need to go down this
  road for now.

But before fixing this issue, what are you trying to do exactly?
Do you intend to reuse this `jami-apply-dependency-patches' procedure
somewhere else?

On a different topic, to avoid sending patch archives in the future, you
could use a public repository clone of Guix.
There are a couple of free services out there, like, maybe, etc.
This would make it smoother to track your progress and help you in the process.

Pierre Neidhardt

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]