Re: qtwenengine anybody?

[Hartmut Goebel]

Am 07.01.20 um 01:27 schrieb address@hidden:
>
>> With these changes, I think the package is ready to go.  \o/
> This is really great work Marius I appreciate this addition. I was
> actually just looking at this approach yesterday. 
>
> I've merged your two patches with one minor description addition that Hartmut
> requested.


Great work you've done! I'm looking forward to get this merged to
master, so I can continue working on some more KDE packages.


> Hartmut the merged complete diff can be found here.
> https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine

Fine for me.

Just some super-nitpicky nitpicks:


> +               (base32
> +               
> "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa"))))

Maybe move has into `base32` line


> +             (define (third-party? file)
> +               (if (string-contains file "third_party/")
> +                   #t
> +                   #f))
The "if" could be omitted, I assume


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | address@hidden               |
| www.crazy-compilers.com | compilers which you thought are impossible |