Re: branch master updated: import/cran: Abort with error message when recursive import fails.

[Ludovic Courtès]

Hi,

guix-commits@gnu.org skribis:

> commit 482b8ae2cd3f126a1300178e317df8993bf75b16
> Author: Ricardo Wurmus <rekado@elephly.net>
> AuthorDate: Sat Dec 12 00:06:18 2020 +0100
>
>     import/cran: Abort with error message when recursive import fails.
>     
>     Previously, after a failed recursive import "guix import" would signal
>     success.
>     
>     * guix/import/cran.scm (cran->guix-package): Raise a condition when all
>     repositories have been exhausted.
>     * guix/scripts/import/cran.scm (guix-import-cran): Handle errors.

[...]

> @@ -585,7 +586,10 @@ s-expression corresponding to that package, or #f on 
> failure."
>               ((bioconductor)
>                ;; Retry import from CRAN
>                (cran->guix-package package-name #:repo 'cran))
> -             (else (values #f '()))))))))
> +             (else
> +              (raise (condition
> +                      (&message
> +                       (message "couldn't find meta-data for R 
> package")))))))))))

Maybe include the package name?

  (raise (formatted-message
          (G_ "couldn't find meta-data for R package '~a'")
          package-name))

Ludo’.