guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Telegram-Desktop]: Help with packaging


From: Raghav Gururajan
Subject: Re: [Telegram-Desktop]: Help with packaging
Date: Fri, 8 Jan 2021 17:52:02 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.0

Hi Mark and Ricardo!

It's more appropriate to use 'for-each' here.  'map' collects all of the
results into a list and returns that list, which is not needed here, and
is slightly less readable.  Also, the second argument to 'find-files' is
optional; omitting it does what's needed more efficiently.  So, in the
interest of promoting better practices, I would recommend this instead:

--8<---------------cut here---------------start------------->8---
          (add-after 'unpack 'make-writable
            (lambda _
              (for-each make-file-writable
                        (find-files "."))
              #t))
--8<---------------cut here---------------end--------------->8---

Thank you for this better variant.  I copied it from an existing
instance in our code.  We should clean those up at some point :)

This worked. :-)

Regards,
RG.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]