[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: alacritty: Update to 0.7.1.
From: |
Tobias Geerinckx-Rice |
Subject: |
Re: [PATCH] gnu: alacritty: Update to 0.7.1. |
Date: |
Tue, 16 Feb 2021 22:41:39 +0100 |
Hi!
Nicolas Goaziou 写道:
As written in the commit message, I removed it because Alacritty
was
working without it
Thank you. That's more than I could infer from a terse ‘Remove
unneeded phase’: you ran it on Wayland [see below] and it worked.
It's OK add rationales like this above the dry changelog (I
mention it only because people have assumed the contrary).
here on my Gnome 3 Wayland session, hence the "unneeded" part.
Are you sure Gnome 3 doesn't run X?
I'd be suprised (and interested) if
DISPLAY= $(guix time-machine --commit=3e10f0e -- \
build alacritty)/bin/alacritty
works for you. It should complain and fail to launch at all,
because it can't connect to the legacy X(wayland) server.
What else was necessary?
I don't know. Maybe more testing, or pinging the original author.
No definitive answers here.
Please bear in mind that:
1. it was not a small version bump, so many things could have
changed in
the package definition;
Right, I had to bump the version numbers, but it wasn't an
unreasonable amount of work.
2. the hack is actually non-trivial as it references packages
that do
not even belong to the inputs but was not even a single
comment line
explaining its importance.
Agreed on both counts: it's a gross hack[0], and it deserves a
comment. I should have added one and will do so now.
Kind regards,
T G-R
[0]: The alternative is stuffing both X libraries into
LD_LIBRARY_PATH, which is grosser...
signature.asc
Description: PGP signature