guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Outreachy - Guix Data Service: implementing basic json output for de


From: Luciana Lima Brito
Subject: Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page
Date: Sat, 17 Apr 2021 14:08:29 +0000

On Sat, 17 Apr 2021 14:11:37 +0100
Christopher Baines <mail@cbaines.net> wrote:

Hi,

> I think that's better, but you're still taking the matched-outputs,
> matched-inputs and matched-sources alists, then later making the
> values vectors rather than lists. The code would be even simpler if
> you converted to a vector just after the map that produces the
> relevant lists.
> 
> I haven't looked to closely at the rest, but it looks like the
> environment-variables binding is unnecessary, given how simple the bit
> of code used is, it can just be inlined in the one place where the
> binding is used.

Done! :)
I even simplified some other stuff, based on what you said.

-- 
Best Regards,

Luciana Lima Brito
MSc. in Computer Science

Attachment: 0001-Implement-basic-json-output-for-the-derivation-compa.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]