[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [core-updates-frozen] Blockers for working system

From: Liliana Marie Prikler
Subject: Re: [core-updates-frozen] Blockers for working system
Date: Sat, 11 Sep 2021 12:11:21 +0200
User-agent: Evolution 3.34.2

Hi Jonathan,

Am Samstag, den 11.09.2021, 00:16 +0200 schrieb Jonathan Brielmaier:
> /gnu/store/2p3lw0dy8b3b34xfn2xlwg9ngrw493v7-gnome-maps-3.38.5.drv
>    Fails in testsuite with:
> JS ERROR: Error: Expected 1,001 m (string) but was 1001 m (string)
> I have no clue why, maybe something is "wrangled" with LC_ALL or LANG
> variables. Or it has to do with our mozjs-78 (used by gjs), where I
> assume comes the `toLocaleString` function from...
There is a phase called "fix-broken-tests" in gnome-maps which patches
exactly those strings to add a comma.  gnome-maps expects the new
behaviour (exactly the one you're observing), but building against an
old mozjs probably borked those tests at the time.  The obvious fix is
to drop that phase as it's no longer needed.

Happy hacking!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]