[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Assisting reviewing & committing with tags?
From: |
Bengt Richter |
Subject: |
Re: Assisting reviewing & committing with tags? |
Date: |
Tue, 15 Feb 2022 13:23:13 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi guix,
It sounds like a good idea, but ISTM we don't need yet another markup syntax
if emacs org mode already defines a useful standard that can be adopted.
The advantage to org mode style [0] -- in commit commentary as well as tags
would be its scrapability -- i.e., ease of writing an extractor/formatter
for handy report snippets/pages and web stuff etc., whether implemented
using foreign shell or within guix.
[0] http://xahlee.info/emacs/emacs/emacs_org_markup.html
On +2022-02-02 08:58:18 -0500, Maxim Cournoyer wrote:
> Hi,
>
> Leo Famulari <leo@famulari.name> writes:
>
> > On Sun, Jan 09, 2022 at 11:54:25AM +0100, Maxime Devos wrote:
> >> Hi guix reviewers and committers,
> >>
> >> WDYT of tagging reviewed patches that look good with a usertag,
> >> e.g. 'reviewed-looks-good':
> >>
> >> https://debbugs.gnu.org/cgi/pkgreport.cgi?tag=reviewed-looks-good&users=guix
> >>
> >> then if a committer doesn't have much time to review and hence doesn't
> >> subscribe to guix-patches@, but they do trust the reviewer, they can visit
> >> that URL to look for reviewed patches that can be applied.
> >>
> >> There could also be a tag 'reviewed-looks-good2' if the patch appears ok
> >> to two reviewers, or a 'reviewed-needs-work', etc.
> >
> > This is a great idea. I guess we will need to adjust the software that
> > runs issues.guix.gnu.org to make use of it, but in the meantime you
> > should keep using this tag. Thanks!
>
> I like it as well.
>
> Maxim
>
--
Regards,
Bengt Richter