[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: npm has irreproducible install behavior
From: |
Ricardo Wurmus |
Subject: |
Re: npm has irreproducible install behavior |
Date: |
Thu, 13 Jul 2023 10:41:14 +0200 |
User-agent: |
mu4e 1.10.3; emacs 28.2 |
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Jelle,
>
>>> I’ve tested this little addition to the build phases of node-lts on an
>>> affected system:
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> (add-after 'install 'do-not-ignore-links
>>> (lambda* (#:key outputs #:allow-other-keys)
>>> (with-directory-excursion
>>> (string-append (assoc-ref outputs "out")
>>> "/lib/node_modules/npm/node_modules")
>>> (substitute* "pacote/lib/fetcher.js"
>>> (("\\/Link\\$\\/.test\\(entry.type\\)")
>>> "false")
>>> (("\\/File\\$\\/.test\\(entry.type\\)")
>>> "/(File|Link)$/.test(entry.type)"))
>>> --8<---------------cut here---------------end--------------->8---
>>
>> The proposed change seems fine to me, provided our QA shows a pretty
>> green button at some point. Could you send a patch that also includes a
>> comment referencing the upstream bug report?
>
> I changed it to patch node-tar instead, because the patch to fetcher.js
> would cause *some* files to be copied to the wrong location.
>
> I’ll send the updated patch to guix-patches today.
Here’s the patch set:
https://issues.guix.gnu.org/64592
The first patch is to clean up the snippet while we’re at it. The
second changes the behavior of node-tar, so that files with hardlinks
are not treated any different from files without.
--
Ricardo