[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#25843: [PATCH 2/2] gnu: Add pzstd.
From: |
Marius Bakke |
Subject: |
bug#25843: [PATCH 2/2] gnu: Add pzstd. |
Date: |
Thu, 23 Feb 2017 23:43:46 +0100 |
User-agent: |
Notmuch/0.23.5 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) |
Tobias Geerinckx-Rice <address@hidden> writes:
> On 23/02/17 16:44, Tobias Geerinckx-Rice wrote:
>> Sure, but I don't much like overriding overrides back to their original
>> values. I prefer the more straightforward (and IMO readable) option of
>> just removing them again.
>
> I've now convinced myself that the use of ‘inherit’ is misplaced here,
> and I should just use package-* directly where needed.
I don't have a strong opinion either way, but found the keyword
substitution difficult to follow (it would be better to simply start
arguments "from scratch" in this case).
I think I prefer just using (package-{source,version,license}) etc where
appropriate, but otherwise keep it "standalone". FWIW I took this
approach in a similar package:
https://github.com/mbakke/guix/commit/154b2816db3c4e79fbf6fd476ec79ef2b2a888cc
Other than that LGTM!
signature.asc
Description: PGP signature
bug#25843: [PATCH 1/2] gnu: Add zstd., Marius Bakke, 2017/02/23